Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove katt from big tests #2835

Merged
merged 10 commits into from
Aug 25, 2020
Merged

Remove katt from big tests #2835

merged 10 commits into from
Aug 25, 2020

Conversation

gustawlippa
Copy link
Contributor

@gustawlippa gustawlippa commented Aug 21, 2020 •
edited
Loading

This PR removes the unneeded katt dependency from big_tests, which does not work with OTP 23.

Katt was simply performing REST requests and checking whether the responses were correct. This PR uses rest_helper from big_tests with some changes to make requests, as the http worker pool is unstable in MIM for now.

@codecov
Copy link

codecov bot commented Aug 21, 2020 •
edited
Loading

Codecov Report

Merging #2835 into master will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2835      +/-   ##
==========================================
+ Coverage   78.07%   78.55%   +0.47%     
==========================================
  Files         373      373              
  Lines       31080    31080              
==========================================
+ Hits        24265    24414     +149     
+ Misses       6815     6666     -149
Impacted Files Coverage Δ
src/pubsub/mod_pubsub.erl 71.86% <0.00%> (-0.12%) ⬇️
src/ejabberd_c2s.erl 89.19% <0.00%> (+0.22%) ⬆️
src/mod_muc_room.erl 77.54% <0.00%> (+0.29%) ⬆️
src/mam/mod_mam_rdbms_arch.erl 39.27% <0.00%> (+0.40%) ⬆️
src/mam/mod_mam_utils.erl 86.08% <0.00%> (+0.64%) ⬆️
src/mod_roster.erl 80.09% <0.00%> (+0.69%) ⬆️
src/global_distrib/mod_global_distrib_utils.erl 66.03% <0.00%> (+0.94%) ⬆️
src/mod_muc_db_rdbms.erl 84.53% <0.00%> (+1.03%) ⬆️
src/inbox/mod_inbox_rdbms.erl 88.09% <0.00%> (+1.19%) ⬆️
src/metrics/mongoose_metrics.erl 94.03% <0.00%> (+1.32%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755dd76...a38f74d. Read the comment docs.

@gustawlippa gustawlippa force-pushed the otp23-remove-katt branch 3 times, most recently from c627ae1 to cbdc086 Compare August 25, 2020 09:55
@gustawlippa gustawlippa changed the title [WIP] Remove katt from big tests Remove katt from big tests Aug 25, 2020
@gustawlippa gustawlippa marked this pull request as ready for review August 25, 2020 09:58
@gustawlippa gustawlippa changed the base branch from otp23 to master August 25, 2020 13:16
NelsonVides
NelsonVides approved these changes Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Suites aren't really pretty, but so they weren't before either.
It is great progress, one overly-complicated dependency less!
I'm merging as soon as CI is green 👍

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 25, 2020 •
edited
Loading

8480.1 / Erlang 22.0 / small_tests / 7c7d4b6
Reports root / small

8480.2 / Erlang 22.0 / internal_mnesia / 7c7d4b6
Reports root/ big
OK: 1481 / Failed: 1 / User-skipped: 157 / Auto-skipped: 0

offline_SUITE:mod_offline_tests:error_message_is_not_stored 
{error,{{badmatch,true},
    [{offline_SUITE,'-error_message_is_not_stored/1-fun-0-',3,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/tests/offline_SUITE.erl"},
             {line,119}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1748}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1263}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1195}]}]}}

Report log

8480.3 / Erlang 22.0 / odbc_mssql_mnesia / 7c7d4b6
Reports root/ big
OK: 2741 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

8480.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 7c7d4b6
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

8480.9 / Erlang 21.3 / pgsql_mnesia / 7c7d4b6
Reports root/ big / small
OK: 2754 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

8480.5 / Erlang 22.0 / riak_mnesia / 7c7d4b6
Reports root/ big
OK: 1602 / Failed: 0 / User-skipped: 177 / Auto-skipped: 0

8480.6 / Erlang 22.0 / ldap_mnesia / 7c7d4b6
Reports root/ big
OK: 1384 / Failed: 0 / User-skipped: 249 / Auto-skipped: 0

8480.4 / Erlang 22.0 / mysql_redis / 7c7d4b6
Reports root/ big
OK: 2736 / Failed: 0 / User-skipped: 233 / Auto-skipped: 0

@NelsonVides NelsonVides merged commit 18e1f08 into master Aug 25, 2020
@NelsonVides NelsonVides deleted the otp23-remove-katt branch August 25, 2020 15:11
@NelsonVides NelsonVides added this to the 4.0.0 milestone Sep 17, 2020
NelsonVides added a commit that referenced this pull request Jan 7, 2021
@NelsonVides
Remove unused katt_helper
b0f2afa 
Usage of this file was removed in #2835, but this file was left behind.
@NelsonVides NelsonVides mentioned this pull request Jan 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelsonVides NelsonVides NelsonVides approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gustawlippa @mongoose-im @NelsonVides